Docs process updated #274
Merged
Docs process updated #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kumare3
commented
Apr 15, 2020
•
kumare3
commented
- Better named makefile targets to generate docs
- Also using a pinned version of Flytekit and FlyteIDL for docs
- Added links to go repos documentation
- Fixed the index and introduction page (there was a duplicate)
added 2 commits
April 8, 2020 18:18
13 tasks
script/generate_docs.sh
Outdated
| @@ -16,13 +16,13 @@ RSTS_DIR=`mktemp -d "${BASEDIR}/rsts_tmp/XXXXXXXXX"` | |||
|
|
|||
| # Copy all rst files to the same place | |||
| cp -R rsts/* ${RSTS_DIR} | |||
| cp -R _rsts/* ${RSTS_DIR} | |||
| #cp -R _rsts/* ${RSTS_DIR} | |||
There was a problem hiding this comment.
I don't remember, what does this do?
There was a problem hiding this comment.
i think we need this, good catch, added back
|
+1 with one comment. approving, not sure if you want to change it |
wild-endeavor
previously approved these changes
Apr 16, 2020
added 2 commits
April 15, 2020 23:24
wild-endeavor
approved these changes
Apr 16, 2020
Right, that should be a follow up PR, I have something in progress, mind helping? |
|
yes ofc.
…On Thu, Apr 16, 2020 at 11:24 AM Ketan Umare ***@***.***> wrote:
but the github workflow doesn't push to gh-pages automatically right? we
still need to do that separately.
Right, that should be a follow up PR, I have something in progress, mind
helping?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#274 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWDFOCVFMXY4VLDJFDYT6LRM5EORANCNFSM4MI4B4MA>
.
|
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 6, 2022
Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 20, 2022
Specify how resource is cleaned up after successful execution of a k8s pod [Issue](flyteorg#2650) Signed-off-by: SmritiSatyanV [email protected] Signed-off-by: SmritiSatyanV <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 20, 2022
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Aug 21, 2023
Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Aug 21, 2023
Specify how resource is cleaned up after successful execution of a k8s pod [Issue](flyteorg#2650) Signed-off-by: SmritiSatyanV [email protected] Signed-off-by: SmritiSatyanV <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Apr 30, 2024
austin362667
pushed a commit
to austin362667/flyte
that referenced
this pull request
May 7, 2024
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
troychiu
pushed a commit
that referenced
this pull request
Jul 8, 2024
## Overview Add some logging to better narrow missing outputs to either admin or propeller paths. In support of https://unionai.atlassian.net/browse/CASE-643 ## Test Plan Unit tests pass + manual inspection ## Rollout Plan (if applicable) Pull over to cloud and deploy admin + propeller ## Upstream Changes Should this change be upstreamed to OSS (flyteorg/flyte)? If so, please check this box for auditing. Note, this is the responsibility of each developer. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F). - [ ] To be upstreamed ## Issue ref CLD-922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.